• 10 dec 2017: forum version update. In case of issues use this topic.
  • 30 nov 2017: pilight moved servers. In case of issues use this topic.
Hello There, Guest! Login Register

Thread Rating:
  • 1 Vote(s) - 4 Average
  • 1
  • 2
  • 3
  • 4
  • 5
When do "Pull-Requests" show up (in Nightly or 'git clone')
Hi all,

I was wondering: there are quite some Pull-Requests on the development branch. I was under the impression that they would show-up somewhere in the Nightly Builds or when doing a "git clone" on the development branch .. but they don't! Wink

What am I missing or what do I do wrong?

Will all the "waiting" pull requests show up in pilight v8?
The PRs shown here https://github.com/pilight/pilight/pulls are proposed PRs that have not been merged into the development or nightly branches yet. They are open for discussion and improvement suggestions, and can still be edited by the contributor who created the PR.

For the changes from a PR to show up in the development or nightly builds, it first needs to be merged by curlymo (who is the maintainer of the pilight repository).
At https://github.com/pilight/pilight/pulls...s%3Amerged you can see all PRs that have been merged.

If you want to test a change from a PR that is not merged yet, you need to compile pilight manually with the PR applied as a patch.
So there is no "time line" for PR to be merged into the development or nightly branches.
I asket because some of the PullRequest that are pending are waiting for more than six months now ..
Version 8 is "in the air" for almost a year which make me think "is pilight still alive?".. Dont get me wrong, I do know this is open source with all the bennefits and pitfalls. I love pilight!
Just take a look again in the rewrite branch and you see that it is. Just not for the end-user perspective.

Also, why is this in protocol develop? Moved to core program.

Possibly Related Threads...
Thread Author Replies Views Last Post
  Assert error in v8.1.3-nightly-d2ee2d0d Ulrich.Arnold 4 970 10-24-2018, 09:28 PM
Last Post: curlymo
  pilight-raw working in nightly? Cipher 8 2,501 08-30-2017, 09:35 PM
Last Post: curlymo
  pilight nightly does not start up, no log entries PT-Biker 4 2,224 06-09-2017, 06:34 AM
Last Post: PT-Biker
  No Heartbeat in Nightly anymore? Cipher 1 957 05-22-2017, 10:02 AM
Last Post: pilino1234
  pilight doesn't show the right status in webgui jurkla 8 3,240 11-17-2016, 09:41 AM
Last Post: gregnau
  Update Error latest Nightly Alex 13 5,167 09-11-2016, 02:51 PM
Last Post: Alex
  Manually-Compiled Nightly | Rules not working Alex 18 7,530 08-20-2015, 06:29 AM
Last Post: Alex
  v6 --> V7 (Nightly) failed -- pl.help gneandr 9 5,016 08-03-2015, 07:09 PM
Last Post: curlymo
  Nightly eisi 9 3,839 05-01-2015, 03:07 PM
Last Post: wo_rasp
  Nightly build error: strlen neevedr 3 3,177 01-24-2015, 03:24 PM
Last Post: curlymo

Forum Jump:

Browsing: 1 Guest(s)