[ma-ca]

The dim action in the rewrite branch fails to execute and I found that the following lines 593-594 in dim.c did cause the error.

Code:

data1->values = json_mkobject();
json_append_member(data1->values, "dimlevel", json_mknumber(data->to_dimlevel, 0));

The following changes did fix the error.

Code:

data1->values = json_mknumber(data->to_dimlevel, 0);  // data1->values = json_mkobject();
data1->values->key = strdup("dimlevel"); //json_append_member(code, "dimlevel", json_mknumber(data->to_dimlevel, 0))

[curlymo]

Can you make sure this fail is triggered in the unittest first?

---

I took me some time to understand why you suggested this change. I assume you mean that the control_device function in the daemon is the issue. If so, i would suggest changing this line in the daemon:

Code:

            jvalues = json_first_child(values);
            while(jvalues) {

It would be great if you could give some more context when you find issues.