• 10 dec 2017: forum version update. In case of issues use this topic.
  • 30 nov 2017: pilight moved servers. In case of issues use this topic.
Hello There, Guest! Login Register


Smartwares switch SH5-RBU-04A and SH5-RBS-04A doesn't work with 8.0.3
#51
Feel free to do a PR on github with those new protocols.
 
Reply
#52
(05-15-2019, 07:06 PM)curlymo Wrote: Feel free to do a PR on github with those new protocols.

I need some help doing it.

For now i have changed some values in arctech_switch.c and compiled pilight. Its working fine now but i'm not doing a PR because i think those changes will break functionality with other devices, i don't have some so i'm unable to check.

First: Here what i changed for someone who will try it out:
Quote:35: #define PULSE_MULTIPLIER 4 -> #define PULSE_MULTIPLIER 5
38: #define AVG_PULSE_LENGTH 315 -> #define AVG_PULSE_LENGTH 260
129: arctech_switch->raw[1]=(9*AVG_PULSE_LENGTH); -> arctech_switch->raw[1]=(10*AVG_PULSE_LENGTH);
173: arctech_switch->raw[131]=(PULSE_DIV*AVG_PULSE_LENGTH); -> arctech_switch->raw[131]=(40*AVG_PULSE_LENGTH);

i'm thinking about the best way to implement for send and receive.
Is it possible to check which brand was selected? Like
if (selected_brand == "smartwares"){
AVG_PULSE_LENGTH  = 260
...
}


Another option might be creating a new protocol but in this case receiving will fail as arctech_switch is correctly detecting this pulses because of wide range of accepted pulse length:
#define MAX_PULSE_LENGTH 320
#define MIN_PULSE_LENGTH 250
so this would result in two protocols matching incoming signals and would need some further tuning...

other ideas?
 
Reply
  


Possibly Related Threads...
Thread Author Replies Views Last Post
  Owsoo Wall Switch (Push Button / Sold for Sonoff devices with 433MHz)) hawkeyexp 0 27 10-14-2019, 10:32 PM
Last Post: hawkeyexp
  Etekcity Switch geokscott 2 813 07-11-2019, 03:48 PM
Last Post: hepcat72
  SW-R01 / Geekbes Wireless Lights Switch gogosjon 0 368 10-13-2018, 05:29 PM
Last Post: gogosjon
  Switch Mumbi m-FS300 display as arctech-switch Rschnauzer 7 1,250 03-24-2018, 07:13 PM
Last Post: Rschnauzer
  Intertek with DIP Switch compuman1 12 8,120 01-15-2018, 07:59 PM
Last Post: madmoses
  Voltomat switch aszepeshazi 1 3,013 12-05-2017, 02:55 AM
Last Post: Archimdes
  [Work in Progress] Rev Ritter aevh 169 75,771 11-22-2017, 06:33 PM
Last Post: curlymo
  REV Switch Typ 8342L madeluxe 4 3,676 08-02-2017, 05:08 PM
Last Post: Flotto
  [Work in progress] somfy controller sandoz 128 45,261 05-06-2017, 10:38 AM
Last Post: wo_rasp
  DS-4 protocol (magnetic switch, EV1527 deviation) torwag 2 1,334 04-23-2017, 10:02 PM
Last Post: curlymo

Forum Jump:


Browsing: 1 Guest(s)