• 10 dec 2017: forum version update. In case of issues use this topic.
  • 30 nov 2017: pilight moved servers. In case of issues use this topic.
Hello There, Guest! Login Register


Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
pilight 8 what chages for custom protocols?
#1
Hi.
I just got pilight 8.0.4 and I cant my custom protocol to work.

I copied compiled file which worked in v7.0-241-gb3b0941  to /usr/local/share/pilight/protocols as I noticed the change in directory placement.

I get error that protocol is not recognized in conif file.

Old links to tutorials etc does not work anymore, no google searches where succesfull.

So my question is  what did change and what is upgrade path of the code?

Thank you.
p.s. I found post pilight 8 work in progress and protocols are mentioned that has change, that is why I am asking this question.
 
Reply
#2
Without any source code i need to guess what may happened.
 
Reply
#3
(01-09-2018, 07:19 AM)curlymo Wrote: Without any source code i need to guess what may happened.

Hi sorry, I thought that there are some new rules for custom protocols.
Code is here: https://www.dropbox.com/s/2g99ui1huoo8j0...901.c?dl=0

It might also be because there was not correctly set permissions.

I move the file to /usr/local/share/pilight/protocols and wanted to look in to tutorial which used to be here https://www.pilight.org/modules/protocols/#register

Would be great-full for any insight.

p.
 
Reply
#4
No, nothing really change for your protocol. However, did you already tried to get this integrated into pilight by default?
 
Reply
#5
(01-09-2018, 07:11 PM)curlymo Wrote: No, nothing really change for your protocol. However, did you already tried to get this integrated into pilight by default?

I would like to, but do not know how to do it.

There are two things which are not done yet.
1. low battery (since the sensor still runs on same battery one year now)
2. check sum

Thanks for info.
p.
 
Reply
#6
The protocol seems already good enough for integration. If you got to this point a pull integration should be easy for you. Just check one of the pull-requests on github.
 
Reply
#7
(01-10-2018, 07:22 AM)curlymo Wrote: The protocol seems already good enough for integration. If you got to this point a pull integration should be easy for you. Just check one of the pull-requests on github.

Hi.
Its quite embarrassing, but I never did pul request, should I create branch first?

The protocol is working fine in new version.

Thank you.
p.
 
Reply
#8
You should follow the contribution guide. That's enough.
 
Reply
#9
(02-14-2018, 07:05 PM)curlymo Wrote: You should follow the contribution guide. That's enough.

Hi.
Just created pull request.

Its embarrassing that it took so long :-)

p.
 
Reply
#10
Hi Iam sorry.

Its not straightforward process for me.
Could you be more specific, what is wrong?

I read that I should merge with development branch, but there is no branch with that name.
Is it staging branch I should use? (point 4)

Should I have created another branch in my repo also? (point 5)

https://github.com/pilight/pilight/blob/...IBUTING.md
 
Reply
  


Possibly Related Threads...
Thread Author Replies Views Last Post
  Bug: double free or corruption in pilight-send blackzombie 12 104 10-07-2019, 08:15 PM
Last Post: blackzombie
  pilight-control modify values coolinx 2 78 09-20-2019, 07:24 PM
Last Post: coolinx
  [Fixed] High CPU usage when pilight usb nano disconnects DieterK 1 132 08-13-2019, 05:43 PM
Last Post: curlymo
  pilight Nano USB interface curlymo 228 97,117 07-10-2019, 06:14 PM
Last Post: curlymo
  problems compiling pilight on Odroid C2 WitchDoctor 101 9,730 03-14-2019, 09:01 PM
Last Post: curlymo
  pilight-debug shows nothing minhdomanh 3 541 10-18-2018, 07:01 AM
Last Post: felfert
  pilight-send and pilight-daemon DieterK 0 558 06-20-2018, 12:44 AM
Last Post: DieterK
  Lights not switched on or off by rules in pilight 8.1.0 rorie 22 2,491 06-12-2018, 03:56 PM
Last Post: curlymo
  check API in pilight 8 stratege-0815 4 1,397 02-11-2018, 09:34 AM
Last Post: stratege-0815
  pilight-receive terminates zackdvd 8 1,655 12-30-2017, 09:07 PM
Last Post: curlymo

Forum Jump:


Browsing: 1 Guest(s)