• 10 dec 2017: forum version update. In case of issues use this topic.
  • 30 nov 2017: pilight moved servers. In case of issues use this topic.
Hello There, Guest! Login Register


Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Wrong description for KAKU protocols
#1
In the configuration options screen shown when building pilight, the description for the KAKU dimmer, -dusk and -motion iis telling that these are "support for the old ... protocol".
Imho that should be "support for the new ... protocol"
 
Reply
#2
You can just open a PR for these findings.
 
Reply
#3
I am now working with the staging branch (8.1.1)  and my current fork is quite old (8.0.3). To make a new PR, I need a fork that is up to date, but I can have only one fork at a time. I still have an open PR for the development branch (generic_label with blink option), but for staging that PR is outdated because of the new events parser.

Can I safely create a new fork and do a PR for the KAKU descriptions, for the staging branch?

Also, must I make a new PR for the label blink option for the staging branch?
 
Reply
#4
Read about feature branches. That means having multiple branches with the same base code leading to the different PR's on the same branch.
 
Reply
#5
Yes, I know I can create multiple branches, but for this new PR I need the current base code (containing version 8.1.1  code),  while my existing PR is based on older base code.
 
Reply
#6
I don't see the issue if we can maintain multiple branches.
 
Reply
  


Possibly Related Threads...
Thread Author Replies Views Last Post
  odd behaviour of kaku dimmers in GUI Niek 18 1,413 06-09-2018, 07:04 PM
Last Post: curlymo
  dimmervalues wrong terrar 13 2,781 08-23-2017, 05:47 PM
Last Post: curlymo

Forum Jump:


Browsing: 1 Guest(s)