Posts: 14
Threads: 2
Joined: Jan 2019
Reputation:
0
First of all, thanks for providing pilight. It is a great tool. I am about to implement a new protocol but I am a little confused about the project structure. The docs say I should create branch based on "development", but this branch seems to be behind "master" and furthermore it does not contain the unit tests. Then there are the "staging" (quite on par with master) and the "rewrite" branches where the latter is also behind but contains unit tests. Are there any recommendations on how to add a new protocol with unit tests?
Second there are many open pull requests and at least the newer protocol related ones seem to be against "staging". Is this the way to submit my code?
Posts: 14
Threads: 2
Joined: Jan 2019
Reputation:
0
Thanks for the fast answer. Some followup questions: Is it only the lua/interfacing/frontend part which is not working in "rewrite"? So if I base my branch on rewrite will I still be able to use all the pilight-* executables when testing it?
And can you tell what the status of the "s_mfy" branch is? I have some blinds controlled by a somfy and would like to integrate them if possible but the branch seems to be separate from the rest of development.
Posts: 14
Threads: 2
Joined: Jan 2019
Reputation:
0
Thank you. I will start from staging then.
Posts: 7,219
Threads: 92
Joined: Aug 2013
Reputation:
76
What would be great, if you do a PR against the contribution guide as well, better describing than i did how to contribute. At least those parts that were unclear to you.
Posts: 7,219
Threads: 92
Joined: Aug 2013
Reputation:
76
I've updated the staging branch contribution guide.
Posts: 14
Threads: 2
Joined: Jan 2019
Reputation:
0
I would be willing to help if possible, although I probably need to update my hardware first because I noticed that 433Mhz is not always 433MHz.